Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button size option not supported yet? #58

Closed
luboskmetko opened this issue Jun 18, 2014 · 3 comments
Closed

Button size option not supported yet? #58

luboskmetko opened this issue Jun 18, 2014 · 3 comments
Assignees
Labels
Milestone

Comments

@luboskmetko
Copy link

Hey,

first of all, nice job on this editor!

I was trying to use button size option but it doesn't work. Isn't it implemented yet or am I doing something wrong?

Using "size": "sm" for example but doesn't seem appropriate Bootstrap classes are generated in the code (only "btn btn-default"). Editor and other options normally work.

Thanks!

@Waxolunist Waxolunist self-assigned this Jun 18, 2014
@Waxolunist Waxolunist added this to the v0.3.2 (current development) milestone Jun 18, 2014
@Waxolunist Waxolunist added the bug label Jun 18, 2014
@Waxolunist
Copy link
Owner

Thx for reporting. It is implemented and it is working. I just forgot the api change mentioned in the documentation on this particular property in the templates.
So to get the correct behaviour in this version us it as follows:

 $('#textarea').wysihtml5({
    toolbar: {
      'html': true
    },
    size: 'sm',
    locale: 'de-DE'
  });

As you can see, size is not part of toolbar, but it should be.

This will change in future versions to the correct behaviour as documented.

I will as well clean up the documentation. One big file is not sufficient.

@luboskmetko
Copy link
Author

Thanks! Indeed it works like this.

@rizkysyaiful
Copy link

@Waxolunist I think you should update the doc here -> https://github.com/bootstrap-wysiwyg/bootstrap3-wysiwyg#buttons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants