Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove show_report capabilities and cosmicqc dependency #21

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Nov 7, 2024

Description

This PR removes show_report capabilities and the cosmicqc dependency. We decided this functionality wasn't as useful as creating plots by hand.

Closes #7

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs requested a review from jenna-tomkinson November 7, 2024 19:17
@d33bs d33bs marked this pull request as ready for review November 7, 2024 19:17
@d33bs d33bs changed the title Remove show_report capabilities and cosmicqc dep Remove show_report capabilities and cosmicqc dependency Nov 7, 2024
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d33bs
Copy link
Member Author

d33bs commented Nov 7, 2024

Thanks @jenna-tomkinson !

@d33bs d33bs merged commit a22bb0d into WayScience:main Nov 7, 2024
9 checks passed
@d33bs d33bs deleted the remove-show-report branch November 7, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple show_report functionality from cosmicqc
2 participants