Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CytoDataFrame from coSMicQC as standalone package #4

Merged
merged 9 commits into from
Oct 30, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Oct 23, 2024

This PR migrates CytoDataFrame from coSMicQC as standalone package (with coSMicQC as a dependency).

Some notes:

  • I tried to keep the code relatively unchanged where possible.
  • Docs have been updated to have a different look and feel from coSMicQC to prevent confusion.
  • We're unable to create multiversioned docs yet until we have a first version (see Update docsite to use sphinx-multiversion (post initial release) #3)
  • I've prepared a "pending" project for PyPI, meaning that we don't yet have a release there but will once we trigger the process from a GitHub Release. Once the project is available on PyPI the dead links in this PR will be active.

Closes #1
References WayScience/coSMicQC#108

@d33bs d33bs marked this pull request as ready for review October 23, 2024 19:25
@d33bs d33bs requested a review from jenna-tomkinson October 23, 2024 19:25
@d33bs
Copy link
Member Author

d33bs commented Oct 30, 2024

Thanks again @jenna-tomkinson for your review of related code from within #6 . As I mentioned in that PR, I'm going to move forward with a merge here under the presumption that your approval cascades here. If I misinterpreted or you feel we should change things please don't hesitate to let me know.

@d33bs d33bs merged commit 9791036 into WayScience:main Oct 30, 2024
@d33bs d33bs deleted the migration branch October 30, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate existing work from coSMicQC
1 participant