-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable adaptive image display adjustments and "bring your own image processor" capabilities #45
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I have a few comments/questions. Thanks for your hard work on testing this and improving it! 🎉
Co-Authored-By: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Thanks @jenna-tomkinson ! After making changes and responding to your comments I'll now merge this in. |
Description
This PR overhauls the image rendering after discovering challenges with display of images across various test datasets. We move to use a default of Contrast Limited Adaptive Histogram Equalization (CLAHE) through skimage and also provide the flexibility for a user to bring their own function to help render images, understanding there may be scenarios where automated adjustments are not sufficient. While working through this I noticed that 16-bit images were downgraded and resulted in poor quality display and as a result, refactored to remove reliance on 8-bit image conversions. This included the outline and mask overlay functions, which also were moved to the image module (they are better treated in isolation outside the CytoDataFrame class).
Closes #39
Closes #30 (and possibly related issues)
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.