Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze Plate 4 and rerun analysis + IC with CellProfiler Parallel #17

Merged
merged 10 commits into from
Jul 17, 2023

Conversation

jenna-tomkinson
Copy link
Member

In this PR, we process Plate 4 images with IC and run the analysis.

At the same time, I am running all the past plates again through IC and analysis with CellProfiler parallel to see how it improves processing speed/computation time.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jenna-tomkinson jenna-tomkinson marked this pull request as ready for review July 17, 2023 14:41
Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. A couple comments. Also, how big are SQLite files? Is it ok to add them here as lfs files or should they be figshare'd

2.cellprofiler_analysis/README.md Outdated Show resolved Hide resolved
@jenna-tomkinson jenna-tomkinson removed the request for review from MattsonCam July 17, 2023 15:10
@jenna-tomkinson
Copy link
Member Author

@gwaybio

Regarding the size of the SQLite file, the maximum size is ~ 330 MB. Git LFS can hold files up to 5 GB, so I think we can keep these on GitHub for now unless needs change.

As well, as discussed in the group, I will rerun the analysis at a later date that calculates the Zernike features + increase the number of workers to see if that improves computational time.

I will merge this PR now, thank you for the review!

@jenna-tomkinson jenna-tomkinson merged commit 1de2e80 into WayScience:main Jul 17, 2023
@jenna-tomkinson jenna-tomkinson deleted the analyze_plate4 branch July 17, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants