Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process CellProfiler Extracted Features #19

Merged
merged 5 commits into from
Jul 19, 2023
Merged

Process CellProfiler Extracted Features #19

merged 5 commits into from
Jul 19, 2023

Conversation

jenna-tomkinson
Copy link
Member

In this PR, we:

  1. Rename SQLite file outputs to include Plate name prefix
  2. Convert SQLite files to parquet with CytoTable
  3. Process converted features with pycytominer to get annotated, normalized, and norm+feature selected features.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jenna-tomkinson jenna-tomkinson marked this pull request as ready for review July 17, 2023 19:16
MattsonCam
MattsonCam approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@MattsonCam MattsonCam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM @jenna-tomkinson, good job! Feel free to let me know if you have any questions.

3.processing_features/scripts/2.normalize_sc.py Show resolved Hide resolved
3.processing_features/scripts/1.annotate_sc.py Show resolved Hide resolved
3.processing_features/scripts/1.annotate_sc.py Outdated Show resolved Hide resolved
3.processing_features/scripts/0.merge_sc_cytotable.py Show resolved Hide resolved
3.processing_features/scripts/1.annotate_sc.py Show resolved Hide resolved
3.processing_features/scripts/3.feature_select_sc.py Show resolved Hide resolved
@jenna-tomkinson jenna-tomkinson removed the request for review from gwaybio July 19, 2023 14:10
@jenna-tomkinson
Copy link
Member Author

@MattsonCam Thank you for the review! I removed @gwaybio review since this PR already has an approval.

I will be merging now!

@jenna-tomkinson jenna-tomkinson merged commit ab9aede into WayScience:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattsonCam MattsonCam MattsonCam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenna-tomkinson @MattsonCam