Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun analysis with Zernike features #20

Merged

Conversation

jenna-tomkinson
Copy link
Member

This PR makes minor changes where I add calculating Zernikes for both magnitudes and phases (in the MeasureObjectIntenistyDistribution module) for both pipelines.

I reran the pipelines to output new SQLite files and reran the processing of the features to get new parquet files (e.g., annotated, normalized, and feature selected).

Copy link
Member

@MikeLippincott MikeLippincott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment I have is wondering if .parquet files are supposed to be .gitignore'd? Other than that LGTM! Ready to merge!

@jenna-tomkinson
Copy link
Member Author

Great point! I am including the parquet files so that they are easily accessible for analysis, and they are pretty small to include.

@MikeLippincott Thank you for the review, I am merging now!

@jenna-tomkinson jenna-tomkinson merged commit 99f7bdb into WayScience:main Jul 24, 2023
@jenna-tomkinson jenna-tomkinson deleted the rerun_analysis_zernike branch July 24, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants