Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create IC module #3

Merged
merged 5 commits into from
Mar 16, 2023
Merged

Create IC module #3

merged 5 commits into from
Mar 16, 2023

Conversation

jenna-tomkinson
Copy link
Member

This PR includes

  • adding the illumination correction module
  • adding the CP pipeline to calculate, perform IC, and save images
  • creating a utils folder with all functions to call in notebooks/py files
  • edit main README to reflect new added module
  • edit download data module import library to reflect utils module

@jenna-tomkinson jenna-tomkinson requested a review from gwaybio March 14, 2023 21:48
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jenna-tomkinson jenna-tomkinson requested a review from d33bs March 14, 2023 22:51
axiomcura
axiomcura approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@axiomcura axiomcura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR! Left some comments! Feel free to take a look

1.cellprofiler_ic/README.md Outdated Show resolved Hide resolved
1.cellprofiler_ic/README.md Outdated Show resolved Hide resolved
utils/cp_utils.py Outdated Show resolved Hide resolved
utils/cp_utils.py Outdated Show resolved Hide resolved
utils/cp_utils.py Show resolved Hide resolved
utils/cp_utils.py Show resolved Hide resolved
utils/cp_utils.py Outdated Show resolved Hide resolved
utils/cp_utils.py Show resolved Hide resolved
utils/cp_utils.py Outdated Show resolved Hide resolved
d33bs
d33bs reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left a few comments and suggestions. Please don't hesitate to let me know if you have any questions.

1.cellprofiler_ic/README.md Outdated Show resolved Hide resolved
1.cellprofiler_ic/README.md Outdated Show resolved Hide resolved
1.cellprofiler_ic/README.md Outdated Show resolved Hide resolved
nf1_cellpainting_env.yml Show resolved Hide resolved
1.cellprofiler_ic/scripts/nf1_ic.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
utils/cp_utils.py Outdated Show resolved Hide resolved
utils/cp_utils.py Outdated Show resolved Hide resolved
1.cellprofiler_ic/scripts/nf1_ic.py Show resolved Hide resolved
@jenna-tomkinson jenna-tomkinson mentioned this pull request Mar 16, 2023
Closed
@jenna-tomkinson
Copy link
Member Author

@d33bs Can you give a last review and approve before I merge? I changed a lot!

@jenna-tomkinson
Copy link
Member Author

@gwaybio @d33bs @axiomcura

I will be merging this now! Thank you for the reviews! 😄

@jenna-tomkinson jenna-tomkinson merged commit fe8c9b3 into WayScience:main Mar 16, 2023
@jenna-tomkinson jenna-tomkinson deleted the ic_module branch March 16, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axiomcura axiomcura axiomcura approved these changes

@d33bs d33bs d33bs approved these changes

@gwaybio gwaybio Awaiting requested review from gwaybio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenna-tomkinson @d33bs @axiomcura