Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop Whole Image Quality Control and Rerun Plate 5 #33

Merged

Conversation

jenna-tomkinson
Copy link
Member

@jenna-tomkinson jenna-tomkinson commented Jan 31, 2024

Develop Whole Image Quality Control and Rerun Plate 5

In this PR, I add whole image quality control to filter out poor quality images and rerun only Plate 5 to generate data to use for analysis and machine learning.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@MattsonCam MattsonCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM @jenna-tomkinson, good job! I left some comments. Maybe I missed this, but did you include the QC data? I didn't see it in the data folder. I'll also look more into the QC data during model training.

@jenna-tomkinson
Copy link
Member Author

@MattsonCam

It LGTM @jenna-tomkinson, good job! I left some comments. Maybe I missed this, but did you include the QC data? I didn't see it in the data folder. I'll also look more into the QC data during model training.

The QC output used for developing thresholds is included in the PR. As for QC-specific data, there is no specific data as we are removing images from being processed during IC, so the SQLite and parquet files downstream are updated to only include cells from the good-quality images.

@jenna-tomkinson
Copy link
Member Author

@MattsonCam Thank you lots for the review! I will be merging now!

@jenna-tomkinson jenna-tomkinson merged commit a95f745 into WayScience:main Feb 7, 2024
@jenna-tomkinson jenna-tomkinson deleted the quality_control_nf1 branch February 7, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants