Update LM and UMAPs #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
No, since this is a univariate test (modeling one feature at a time) it is ok to apply LM on the normalized data. I'll review now! |
|
Thank you for the answer I appreciate it! 😄 |
gwaybio
approved these changes
Mar 7, 2024
|
@gwaybio Thanks for the review! I am merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update LM and UMAPs
In this PR, Plate 5 UMAP and LMs are added. The next steps after this PR are to create a CSV of LM coefficients from combined plate data (Plates 5, 3, and 3 prime) and UMAP with Plates 5, 3, and 3 prime together.
Question for @gwaybio:
For the LM coefficients of the combined data, will I need to combine the normalized data and then perform feature selection with all plates together before generating the LM coefficients?