Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software garden and add figshare DOIs #52

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

jenna-tomkinson
Copy link
Member

@jenna-tomkinson jenna-tomkinson commented Aug 16, 2024

Software garden and add figshare DOIs

In this PR, software gardening is performed to ensure reproducibility and figshare DOIs per plate were added to the main README and the README was simplified to remove the platemap figures that from my perspective could be a bit distracting.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think you need to rerun the downloading notebook to test plate 5.

0.download_data/scripts/download_plates.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@jenna-tomkinson
Copy link
Member Author

@gwaybio Testing it now, it took 50 minutes to get all 4 plates downloaded. I am expecting an hour and 20 minutes before it is done. Once it is tested, I will merge this PR.

Thanks!

@jenna-tomkinson
Copy link
Member Author

It has been tested. Plate_4 seemed to have a slight folder bug but given bandwidth, it would take a while to figure out so I am assuming it was a bug from rerunning.

I am merging now, thank you @gwaybio!

@jenna-tomkinson jenna-tomkinson merged commit 9ff205a into WayScience:main Aug 19, 2024
@jenna-tomkinson jenna-tomkinson deleted the add_figshare_DOIs branch August 19, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants