-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eda #5
base: main
Are you sure you want to change the base?
Eda #5
Conversation
…timelapse into eda
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small things, but otherwise LGTM!
|
||
# run the scripts | ||
# python 0.preprocess_profiles.py | ||
# python 1.eda_compute.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this commented out?
import pyarrow.parquet as pq | ||
|
||
|
||
# In[ ]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this wasn't run all the way through
data.head() | ||
|
||
# perform preprocessing on each data | ||
# sort the time and replace with 1, 2, 3, 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this done?
from sklearn.decomposition import PCA | ||
|
||
|
||
# In[ ]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also doesn't seem to be run all the way through
This PR performs EDA on the data