main: ignore SIGPIPE globally. #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, writing to a pipe that has been closed terminates the program with SIGPIPE. Ignoring SIGPIPE results in the syscall failing with EPIPE instead. This generally prevents crashing on IPCs. One crash I found is in write_selection_property_to_wl_client when using xpra to run remote apps. If xpra updates the selection too often, wayfire crashes with SIGPIPE. But this probably prevents other crashes in general. It also matches what other compositors do, e.g., sway also globally ignores SIGPIPE to prevent crashes caused by IPCs.
|
Thanks! |
lilydjwg
pushed a commit
to lilydjwg/wayfire
that referenced
this pull request
Jan 21, 2024
By default, writing to a pipe that has been closed terminates the program with SIGPIPE. Ignoring SIGPIPE results in the syscall failing with EPIPE instead. This generally prevents crashing on IPCs. One crash I found is in write_selection_property_to_wl_client when using xpra to run remote apps. If xpra updates the selection too often, wayfire crashes with SIGPIPE. But this probably prevents other crashes in general. It also matches what other compositors do, e.g., sway also globally ignores SIGPIPE to prevent crashes caused by IPCs.
ammen99
pushed a commit
that referenced
this pull request
Mar 13, 2024
By default, writing to a pipe that has been closed terminates the program with SIGPIPE. Ignoring SIGPIPE results in the syscall failing with EPIPE instead. This generally prevents crashing on IPCs. One crash I found is in write_selection_property_to_wl_client when using xpra to run remote apps. If xpra updates the selection too often, wayfire crashes with SIGPIPE. But this probably prevents other crashes in general. It also matches what other compositors do, e.g., sway also globally ignores SIGPIPE to prevent crashes caused by IPCs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, writing to a pipe that has been closed terminates the program with SIGPIPE. Ignoring SIGPIPE results in the syscall failing with EPIPE instead.
This generally prevents crashing on IPCs. One crash I found is in write_selection_property_to_wl_client when using xpra to run remote apps. If xpra updates the selection too often, wayfire crashes with SIGPIPE. But this probably prevents other crashes in general. It also matches what other compositors do, e.g., sway also globally ignores SIGPIPE to prevent crashes caused by IPCs.