Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: do not resize view in move_view_to_output #2211

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Conversation

ammen99
Copy link
Member

@ammen99 ammen99 commented Mar 13, 2024

We already changed the behavior similarly in #2123, so it should be fine to change it here too.

@mark-herbert42
Copy link

Works perfectly - no more window growth when disconnecting external display.

@mark-herbert42
Copy link

I've opened a bug in wf-shell regarding wf-background crash - it seems to belong there, not a wf core functionality. The way it crashes very much look that it still tries to paint next wallpaper image on disconnected monitor. Wf-background is detecting the new monitor well and paint the active wallpaper on it immediately. When monitor is disconnected and time comes to paint a new wallpaper - then new wallpaper appersr on the main monitor and then it crahes almost imeediately, sometimes I can see the new wallper well somertimes it crahes in the middle of animation. So seems that wf-wallpaper does not catch the output discinnect event properly, but clearly works well when monitor is connected.

I've compiled wf-shell from current git.

ammen99 added 2 commits March 13, 2024 11:15
In Xwayland, it is possible to get situations where priv->wsurface is
dangling because we delay unmap until next idle.

So what happens is that a surface is unmappad and then dissociated,
while the unmap transaction is still pending. In such cases it
appears as if priv->wsurface is set but it can be dangling.
@ammen99 ammen99 merged commit 390aff1 into master Mar 13, 2024
8 checks passed
@ammen99 ammen99 deleted the fix-transfer-to branch March 13, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants