Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipc-rules: add mechanism to connect signals only when a subscriber is really there #2267

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

ammen99
Copy link
Member

@ammen99 ammen99 commented Mar 26, 2024

Alternative to #2262

@CharlieQLe @killown Please take a look and test.

@ammen99 ammen99 force-pushed the ipc-rules-optimizations branch from 2e37433 to cbdbe35 Compare March 26, 2024 06:07
@ammen99 ammen99 force-pushed the ipc-rules-optimizations branch from cbdbe35 to 92fe17b Compare March 26, 2024 06:10
@CharlieQLe
Copy link
Contributor

Doesn't seem to break anything, my custom bar runs perfectly fine and I have a Python script that prints out all the events as they come. Not too sure if output events are sent properly though, mostly because hotplugging one of my monitors seems to freeze everything. Not sure if this is a problem with Wayfire, Wlroots, Wayland, Linux, etc. or just something weird with my setup since this started happening back when I used Hyprland.

@ammen99
Copy link
Member Author

ammen99 commented Mar 26, 2024

Doesn't seem to break anything, my custom bar runs perfectly fine and I have a Python script that prints out all the events as they come. Not too sure if output events are sent properly though, mostly because hotplugging one of my monitors seems to freeze everything. Not sure if this is a problem with Wayfire, Wlroots, Wayland, Linux, etc. or just something weird with my setup since this started happening back when I used Hyprland.

Thanks for testing! About the freeze, I would say a wlroots or kernel bug, since it happens in Hyprland too. I would recommend looking at Wayfire's logs (stdout) or dmesg, maybe you will see something related.

@ammen99 ammen99 merged commit 8364a65 into master Mar 26, 2024
8 checks passed
@ammen99 ammen99 deleted the ipc-rules-optimizations branch March 26, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants