Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix excusive zone when zwf_shell_manager_v2 is unavailable #199

Merged

Commits on Nov 30, 2023

  1. Fix excusive zone when zwf_shell_manager_v2 is unavailable

    Commit `6652635` fixed autohide issues when `zwf_shell_manager_v2` isn't
    available, but changed, as a side effect, the behaviour of the window's
    `auto_exclusive_zone`, causing an unnecessary dependency on the
    `zwf_shell_manager_v2` for the exclusive zone as well, affecting
    wf-panel when the compositor's wayfire-shell plugin is disabled (see
    issue WayfireWM#198 for details).
    
    Fix it by refactoring the `WayfireAutohidingWindow` class, dividing some
    methods charged with too much roles (i.e the
    `WayfireAutohidingWindow::set_autoexclusive_zone()`), transfering
    constructor code into new methods, introducing some new logic controls
    both in the class body and in the callbacks.
    
    Signed-off-by: Ágatha Isabelle Moreira Guedes <me@agatha.dev>
    devlavender committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    3652736 View commit details
    Browse the repository at this point in the history
  2. Remove zwf_support boolean

    As suggested in PR WayfireWM#199 [1], this information is better retrieved by
    checking whether `output->output` is not NULL.
    
    [1] WayfireWM#199 (comment)
    
    Signed-off-by: Ágatha Isabelle Moreira Guedes <me@agatha.dev>
    devlavender committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    e4240e5 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Remove autohide_enabled boolean

    As suggested [1], remove the `autohide_enable` boolean and rely on the
    previously existing ones only.
    
    [1] Comments for Pull-Request WayfireWM#199.
    WayfireWM#199 (comment)
    
    Signed-off-by: Ágatha Isabelle Moreira Guedes <me@agatha.dev>
    devlavender committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    c334112 View commit details
    Browse the repository at this point in the history