Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panel: middle click to close window #210

Merged
merged 6 commits into from
Jan 18, 2024

Conversation

carterprince
Copy link
Contributor

No description provided.

@@ -186,6 +186,10 @@ class WayfireToplevel::impl
{
menu.popup(event->button, event->time);
return true; // It has been handled.
} else if ((event->type == GDK_BUTTON_PRESS) && (event->button == 2)) // middle click
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should only be enabled with an option that is disabled by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

metadata/panel.xml Outdated Show resolved Hide resolved
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ammen99 ammen99 merged commit 2e6e66b into WayfireWM:master Jan 18, 2024
1 of 2 checks passed
ammen99 pushed a commit that referenced this pull request Mar 13, 2024
* panel: middle click to close window

* fix spacing, remove tab

* add option

* remove include widget.hpp, fix whitespace

* move to separate option group

* uncrustify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants