window-list: use ~/.local/share when looking for apps / icons #225
Conversation
|
Somehow I'm thinking this should rely on XDG_DATA_DIRS to do the right thing. Consider Gio::DesktopAppInfo::create() here. |
|
I think @soreau is right, probably if we try the create() method first, we would most likely be able to cover this case and even a few others. |
lcolitti
force-pushed
the
window-list-icon-homedir
branch
from
fb69c9b
to
631ead1
Compare
Ah yes, that looks much better. Thanks for the suggestion! |
The icons in the window list are loaded by parsing the .desktop files for a few variations of the window's app ID in a few known locations. This doesn't look everywhere it should - for example, it doesn't look into ~/.local/share/applications or look at XDG_DATA_DIRS. Use the standard Gio::DesktopAppInfo::create instead.
lcolitti
force-pushed
the
window-list-icon-homedir
branch
from
631ead1
to
cf94c16
Compare
|
Looks like the CI tests are broken for unrelated reasons: |
|
@lcolitti We can probably use |
Yup, definitely looks happier after changing that. |
|
Bonus points for removing more lines than added. 👍 |
The icons in the window list are loaded by parsing the desktop files for a few variations of the window's app ID in a few known locations.
Add /.local/share/applications to the list of locations it looks in, to ensure that apps installed in the user's home directory are considered as well.