Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

background: free old image after transition #249

Merged
merged 1 commit into from
Apr 25, 2024
Merged

background: free old image after transition #249

merged 1 commit into from
Apr 25, 2024

Conversation

trigg
Copy link
Contributor

@trigg trigg commented Apr 22, 2024

No description provided.

ammen99
ammen99 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Does this help with reduction of RAM usage? (I expect it should halve it)

@trigg
Copy link
Contributor Author

trigg commented Apr 25, 2024

This PR lowered the ram usage in my tests, but unfortunately not by half.

@ammen99
Copy link
Member

ammen99 commented Apr 25, 2024

This PR lowered the ram usage in my tests, but unfortunately not by half.

I guess it also depends on the background image's resolution. But any reduction is good :)

@ammen99 ammen99 merged commit 37beec0 into WayfireWM:master Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammen99 ammen99 ammen99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trigg @ammen99