Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PublicMaps should be PrivateMaps #401

Closed
Nightinggale opened this issue Jan 6, 2021 · 1 comment
Closed

PublicMaps should be PrivateMaps #401

Nightinggale opened this issue Jan 6, 2021 · 1 comment
Assignees
@Nightinggale
Labels
Annoyance Features that annoy the player \ disturb the game flow
Milestone
2.8.2

Comments

@Nightinggale
Copy link
Contributor

Nightinggale commented Jan 6, 2021 •
edited
Loading

The Civ4 engine has two places for map scripts

  • PublicMaps
  • PrivateMaps

The difference is that public maps are available to all mods while private maps are mod specific. FaireWeather requires our python/dll to work and as such doesn't work in other mods or vanilla. This becomes a problem when people load vanilla since the game loads the last used map script from the ini file and does something with it. This results in a torrent of errors before reaching the main menu.

This is fixed by simply renaming the folder. However doing so right now is prone to cause merging issues now that we have a lot of modified files in that folder due to large rivers.

Semi related: a number of people opens vanilla and then pick load mod from the main menu. The awareness of using the mod="whatever" argument in a shortcut seems to be close to non existing.
@Nightinggale Nightinggale added the Annoyance Features that annoy the player \ disturb the game flow label Jan 6, 2021
@Nightinggale Nightinggale added this to the 2.8.2.2 milestone Jan 6, 2021
@Nightinggale Nightinggale self-assigned this Jan 6, 2021
@raystuttgart
Copy link
Collaborator

Sounds good.
Had not yet thought about that.

And yes, 95% of our players seem to not know that the mod can be started directly with the shortcut.

@Nightinggale Nightinggale mentioned this issue Jan 20, 2021
Closed
Nightinggale added a commit that referenced this issue Apr 24, 2021
@Nightinggale
Fix #401: Loading vanilla will no longer complain about a missing str…
f620bc6 
…ing due to WTP mapscript

This is done by turning our PublicMaps into PrivateMaps. THis means they are only visible to this mod.
PublicMaps are visible to other mods as well as vanilla.
The error is caused when vanilla tries to read our WTP only FaireWeather mapscript.
For whatever reason, the game will load something from the last used mapscript before reaching the main menu.

This also ensures that players will only see files intended for the current version.
Useful if we add a new file in the future and somebody has two versions installed.
The new file won't be loaded by the old version of the mod.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nightinggale Nightinggale

Labels
Annoyance Features that annoy the player \ disturb the game flow
Projects
None yet
Milestone
2.8.2
Development

No branches or pull requests
2 participants
@Nightinggale @raystuttgart