Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

after the destruction of the colony, trade routes did not leave #466

Closed
MrZorG33 opened this issue May 24, 2021 · 2 comments
Closed

after the destruction of the colony, trade routes did not leave #466

MrZorG33 opened this issue May 24, 2021 · 2 comments
Assignees
@Nightinggale

Comments

@MrZorG33
Copy link
Collaborator

during the war with the natives, two colonies were destroyed. however, trade routes remained. I now have two trade routes with an unknown destination. because of this, wagon trains are loaded with stones and do not move. why trade routes were left with only a stone - I cannot understand.

image
war.zip
@Nightinggale Nightinggale self-assigned this May 24, 2021
@raystuttgart
Copy link
Collaborator

raystuttgart commented May 24, 2021 •
edited
Loading

Yeah, stuff like that can easily happen in programming.
You sometimes simply do not consider every use case as a programmer.
Most likely I would also have forgotten to regularly check the alredy created / stored Trade Routes (each turn) if they are still valid.

Nightinggale added a commit that referenced this issue May 25, 2021
@Nightinggale
Fix #466 Traderoutes are now always removed if a colony is destroyed
a7fbfc9 
A certain combination with import feeder could prevent imports from being turned off when a colony died.
This left trade routes behind, which would export to said colony.
Without a destination the transports would stall.

This fix prevents it from happening again, but won't fix existing savegames.
However existing savegames can be fixed by turning off export to remove the broken trade routes.
@Nightinggale
Copy link
Contributor

Fixed.

Vanilla code turned import off, but then feeder service turned it back on. Now CvCity::kill will also turn auto export and feeder service off, preventing this from happening again.

Fixing the existing savegame can be done by turning off export of stone in Novo Arkhangelsk as that kills all trade routes with stone starting from this colony. It can then be turned on again right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nightinggale Nightinggale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Nightinggale @raystuttgart @MrZorG33