Conversation
- 이벤트 객체명 변경(FollowEvent -> UserFollowEvent) - 이벤트 객체 필드 변경(Entity -> DTO) - dispatch에서 리스너로 처리 위치 변경 (단순화)
워크스루팔로우 알림 처리 로직이 직접 디스패처 호출에서 이벤트 기반 리스너 패턴으로 변경되었습니다. 기존 변경 사항
예상 코드 리뷰 난이도🎯 3 (Moderate) | ⏱️ ~20 분 관련 PR 목록
시
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/test/http/noti/noti-api.http`:
- Line 35: The follow target nickname in the HTTP test uses followNickname=1등
but the script only creates the receiver user, so the test can 404; either
change the followNickname to the receiver's actual nickname (the created user)
or add a setup request that creates a user with nickname "1등" before the POST
/api/v1/users/follow call; update the test to ensure the created user's nickname
matches the followNickname parameter (reference the followNickname query param
and the receiver user creation step).
|
|
||
| ### 팔로우 요청 | ||
| POST http://localhost:8080/api/v1/users/follow?followNickname=receiver | ||
| POST http://localhost:8080/api/v1/users/follow?followNickname=1등 |
There was a problem hiding this comment.
팔로우 대상 닉네임이 사전 생성 사용자와 불일치합니다.
이 스크립트에서는 receiver만 가입시키는데 followNickname=1등이면 초기 DB에서 404가 날 수 있습니다. 닉네임을 맞추거나 1등 사용자 생성 단계를 추가해 주세요.
💡 수정 제안
-POST http://localhost:8080/api/v1/users/follow?followNickname=1등
+POST http://localhost:8080/api/v1/users/follow?followNickname=receiver📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| POST http://localhost:8080/api/v1/users/follow?followNickname=1등 | |
| POST http://localhost:8080/api/v1/users/follow?followNickname=receiver |
🤖 Prompt for AI Agents
In `@src/test/http/noti/noti-api.http` at line 35, The follow target nickname in
the HTTP test uses followNickname=1등 but the script only creates the receiver
user, so the test can 404; either change the followNickname to the receiver's
actual nickname (the created user) or add a setup request that creates a user
with nickname "1등" before the POST /api/v1/users/follow call; update the test to
ensure the created user's nickname matches the followNickname parameter
(reference the followNickname query param and the receiver user creation step).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Pull Request
📌 PR 종류
해당하는 항목에 체크해주세요.
✨ 변경 내용
팔로우 이벤트 발행 로직에 대한 리팩토링 수행했습니다.
🔍 관련 이슈
🧪 테스트
변경된 기능에 대한 테스트 범위 또는 테스트 결과를 작성해주세요.
직접적인 http 테스트를 통해 actor/receiver 데이터 비교 진행했습니다.
🚨 확인해야 할 사항 (Checklist)
PR을 제출하기 전에 아래 항목들을 확인해주세요.
🙋 기타 참고 사항
리뷰어가 참고하면 좋을 만한 추가 설명이 있다면 적어주세요.
Summary by CodeRabbit
릴리스 노트
✏️ Tip: You can customize this high-level summary in your review settings.