Skip to content

[FEAT] 모임 이미지 삭제 응답 형식 개선 #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LimdaeIl merged 2 commits into from
Dec 11, 2025
Merged

[FEAT] 모임 이미지 삭제 응답 형식 개선 #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cac47a
♻️refactor: 이미지 삭제 응답 No Content 204로 개선 [#75]
LimdaeIl Dec 11, 2025
8c527d1
♻️refactor: 내 모임 조회 테스트 .http 입력 날짜 수정 [#75]
LimdaeIl Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/main/java/team/wego/wegobackend/group/presentation/GroupImageController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,7 @@ public ResponseEntity<ApiResponse<Void>> deleteGroupImages(
) {
groupImageService.deleteGroupImages(userDetails, groupId);

return ResponseEntity
.status(HttpStatus.OK)
.body(ApiResponse.success(HttpStatus.OK.value(), null));
return ResponseEntity.noContent().build();
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type declaration ResponseEntity<ApiResponse<Void>> doesn't match the actual return statement ResponseEntity.noContent().build() which returns ResponseEntity<Void>. The method signature should be updated to ResponseEntity<Void> to match the implementation, or the implementation should wrap the response in ApiResponse to match the signature.

Suggested change
return ResponseEntity.noContent().build();
return ResponseEntity
.status(HttpStatus.NO_CONTENT)
.body(ApiResponse.success(HttpStatus.NO_CONTENT.value(), null));

Copilot uses AI. Check for mistakes.
}

}
14 changes: 2 additions & 12 deletions src/test/http/group/group-me.http
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ Authorization: Bearer {{hostAccessToken}}
"title": "강남 자바 스터디 - PAST",
"location": "서울 강남구",
"locationDetail": "강남역 2번 출구 근처 카페",
"startTime": "2026-01-10T19:00:00",
"endTime": "2026-01-10T21:00:00",
"startTime": "2025-01-10T19:00:00",
"endTime": "2025-01-10T21:00:00",
"tags": [
"자바",
"과거모임"
Expand Down Expand Up @@ -188,7 +188,6 @@ Authorization: Bearer {{hostAccessToken}}

> {%
const data = response.body.data;
console.log("[HOST] current page1:", data.items);

const nextCursor = data.nextCursor;
if (nextCursor !== null && nextCursor !== undefined) {
Expand All @@ -202,7 +201,6 @@ Authorization: Bearer {{hostAccessToken}}

> {%
const data = response.body.data;
console.log("[HOST] current page2:", data.items);
%}


Expand All @@ -212,7 +210,6 @@ Authorization: Bearer {{hostAccessToken}}

> {%
const data = response.body.data;
console.log("[HOST] myPost page1:", data.items);

const nextCursor = data.nextCursor;
if (nextCursor !== null && nextCursor !== undefined) {
Expand All @@ -226,7 +223,6 @@ Authorization: Bearer {{hostAccessToken}}

> {%
const data = response.body.data;
console.log("[HOST] myPost page2:", data.items);
%}


Expand All @@ -236,7 +232,6 @@ Authorization: Bearer {{hostAccessToken}}

> {%
const data = response.body.data;
console.log("[HOST] past page1:", data.items);

const nextCursor = data.nextCursor;
if (nextCursor !== null && nextCursor !== undefined) {
Expand All @@ -250,7 +245,6 @@ Authorization: Bearer {{hostAccessToken}}

> {%
const data = response.body.data;
console.log("[HOST] past page2:", data.items);
%}

### 5-1. MEMBER1 기준 - 현재 참여 중인 모임 (type=current, 첫 페이지)
Expand All @@ -259,7 +253,6 @@ Authorization: Bearer {{member1AccessToken}}

> {%
const data = response.body.data;
console.log("[MEMBER1] current page1:", data.items);

const nextCursor = data.nextCursor;
if (nextCursor !== null && nextCursor !== undefined) {
Expand All @@ -273,7 +266,6 @@ Authorization: Bearer {{member1AccessToken}}

> {%
const data = response.body.data;
console.log("[MEMBER1] current page2:", data.items);
%}


Expand All @@ -283,7 +275,6 @@ Authorization: Bearer {{member1AccessToken}}

> {%
const data = response.body.data;
console.log("[MEMBER1] past page1:", data.items);

const nextCursor = data.nextCursor;
if (nextCursor !== null && nextCursor !== undefined) {
Expand All @@ -297,5 +288,4 @@ Authorization: Bearer {{member1AccessToken}}

> {%
const data = response.body.data;
console.log("[MEMBER1] past page2:", data.items);
%}
Loading