Conversation
|
Caution Review failedThe pull request is closed. 개요두 개의 CORS 설정 파일에 로컬 개발 환경용 오리진을 추가했습니다. CorsConfig에는 포트 3000을 포함한 오리진을 추가하고, SecurityConfig에는 포트 없는 오리진과 포트를 포함한 오리진을 모두 추가했습니다. 변경 사항
코드 리뷰 예상 소요 시간🎯 1 (Trivial) | ⏱️ ~5분
관련 이슈
축하 시
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-project-automation
bot
moved this from In progress
to Done
in WeGo-Together Backend
There was a problem hiding this comment.
Pull request overview
This PR adds CORS configuration for the local development environment by including https://local.wego.monster:3000 as an allowed origin. The change is applied consistently across both CORS configuration locations.
- Adds new allowed origin
https://local.wego.monster:3000to support local development environment
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| SecurityConfig.java | Adds https://local.wego.monster:3000 to the CORS allowed origins list in Spring Security configuration |
| CorsConfig.java | Adds https://local.wego.monster:3000 to the CORS allowed origins list in web MVC configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "https://local.wego.monster", | ||
| "https://local.wego.monster:3000")); |
There was a problem hiding this comment.
The origin https://local.wego.monster:3000 uses HTTPS protocol with port 3000, which is unusual. Port 3000 is typically used for HTTP development servers (like the existing http://localhost:3000 entry). If this is intended for local development, it should likely be http://local.wego.monster:3000 instead. If HTTPS is intentional, verify that the local development server is actually configured to run HTTPS on port 3000.
| "https://local.wego.monster", | |
| "https://local.wego.monster:3000")); | |
| "https://local.wego.monster")); |
| "https://local.wego.monster", | ||
| "https://local.wego.monster:3000" |
There was a problem hiding this comment.
The origin https://local.wego.monster:3000 uses HTTPS protocol with port 3000, which is unusual. Port 3000 is typically used for HTTP development servers (like the existing http://localhost:3000 entry). If this is intended for local development, it should likely be http://local.wego.monster:3000 instead. If HTTPS is intentional, verify that the local development server is actually configured to run HTTPS on port 3000.
| "https://local.wego.monster", | |
| "https://local.wego.monster:3000" | |
| "https://local.wego.monster" |
1 participant
📝 Pull Request
📌 PR 종류
해당하는 항목에 체크해주세요.
✨ 변경 내용
[FEAT] 개발환경에서도 되도록 추가 CORS
🔍 관련 이슈
🧪 테스트
변경된 기능에 대한 테스트 범위 또는 테스트 결과를 작성해주세요.
🚨 확인해야 할 사항 (Checklist)
PR을 제출하기 전에 아래 항목들을 확인해주세요.
🙋 기타 참고 사항
리뷰어가 참고하면 좋을 만한 추가 설명이 있다면 적어주세요.
Summary by CodeRabbit
릴리스 노트
✏️ Tip: You can customize this high-level summary in your review settings.