feat: Custom log and error handlers #142

DhansAL · 2021-12-16T08:30:24Z

Description

This closes issue #141 and adds some code enhancements.

what this pull request includes :

custom log and error handlers which include additional features like,

logging according to the severity of bug or log ( 7 different levels )
the capability to export all the logs of different levels to an external log file while production
control over console format (include timestamps etc )

Added error handling on all modules.
Restructured the code, added src directory.

Check List (mark all applicable checkboxes)

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
All new and existing tests passed.
This PR does not contain plagiarized content.
The title of my pull request is a short description of the requested changes.

Screenshots (if applicable)

Original	Updated
original screenshot	updated screenshot

add src directory and refactor imports

add a custom loghandler util function

create a custom error handler with sending error as embbed message functionality

restructure code ,create custom loggers,add error handling in all modules

github-actions

Yeah! You did it 🎉 Now, Relax 😉 -> Grab a drink ☕ -> And wait for the maintainers to check your contributions. Meanwhile, you can discuss on other issues and solve them 😀

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server - we help and encourage each other to contribute to open source little and often 🤓 Any questions, let us know!

Panquesito7

Awesome work! 🚀

src/Commands/DSA.js

Panquesito7 · 2021-12-16T17:04:57Z

src/Commands/DSA.js

+						value: 'https://github.com/kunal-kushwaha/DSA-Bootcamp-Java',
+					},
+					{
+						name: 'Try hands on git',


Suggested change

name: 'Try hands on git',

name: 'Try hands on Git',

src/Commands/help.js

src/Commands/links.js

src/Commands/DSA.js

Panquesito7 · 2021-12-16T17:06:03Z

src/Commands/links.js

+						value: 'https://www.instagram.com/commclassroom/',
+					},
+					{
+						name: 'Youtube',


Suggested change

name: 'Youtube',

name: 'YouTube',

Panquesito7 · 2021-12-16T17:06:39Z

src/Commands/presence.js

+			activity: {
+				name: 'cm!help',
+				type: 'LISTENING',
+				url: 'https://github.com/commclassroom/classroom-monitor-bot.',


I think this dot should be removed.

Suggested change

url: 'https://github.com/commclassroom/classroom-monitor-bot.',

url: 'https://github.com/commclassroom/classroom-monitor-bot',

src/Commands/source.js

Panquesito7 · 2021-12-16T17:07:25Z

src/Commands/source.js

+					'https://discord.js.org'
+				)
+				.setDescription(
+					'Open source discord bot made for ✨Community Classroom✨'


Suggested change

'Open source discord bot made for ✨Community Classroom✨'

'Open Source Discord bot made by and for ✨Community Classroom✨'

Panquesito7 · 2021-12-16T17:07:33Z

src/Commands/source.js

+					'Open source discord bot made for ✨Community Classroom✨'
+				)
+				.addFields({
+					name: 'Github',


Suggested change

name: 'Github',

name: 'GitHub',

DhansAL · 2021-12-17T03:20:34Z

done ^_^

DhansAL · 2021-12-19T06:23:39Z

if there's a problem with my pull request? please let me know ^_^

siddhant-khisty

Looks good except for a few typos. Please fix the typos suggested by Panquesito. Also kindly remove the University Leader field as the program is discontinued

siddhant-khisty · 2021-12-20T03:24:13Z

src/Commands/links.js

+						value: 'https://t.me/commclassroom',
+					},
+					{
+						name: 'Become University Leader',


University Leader Program was discontinued. Kindly Remove this field

DhansAL · 2021-12-20T12:26:29Z

I have removed all typos and the deprecated University field leader code. please have a look :)

siddhant-khisty

LGTM

src/Commands/DSA.js

Panquesito7 · 2021-12-21T20:00:08Z

src/Commands/help.js

+				.setTitle('Community monitor for help')
+				.setURL('https://github.com/commclassroom/classroom-monitor-bot')
+				.setAuthor(
+					'Classroon monitor',


Suggested change

'Classroon monitor',

'Classroom Monitor',

Panquesito7 · 2021-12-21T20:00:29Z

src/Commands/help.js

+try {
+	module.exports = {
+		name: 'help',
+		description: 'sends the help command',


Suggested change

description: 'sends the help command',

description: 'Sends a list of valid commands (a.k.a. help command)',

Panquesito7 · 2021-12-21T20:01:22Z

src/Commands/links.js

+try {
+	module.exports = {
+		name: 'links',
+		description: 'sends the link relevant to comm classroom',


Suggested change

description: 'sends the link relevant to comm classroom',

description: 'Sends all Community Classroom's socials',

Panquesito7 · 2021-12-21T20:01:35Z

src/Commands/links.js

+				.setTitle('Community Classroom Social accounts')
+				.setURL('https://github.com/commclassroom/classroom-monitor-bot')
+				.setAuthor(
+					'Classroon monitor',


Suggested change

'Classroon monitor',

'Classroom Monitor',

Panquesito7 · 2021-12-21T20:01:53Z

src/Commands/source.js

+try {
+	module.exports = {
+		name: 'source',
+		description: 'sends the source code of the bot',


Suggested change

description: 'sends the source code of the bot',

description: 'Sends a link to the bot's source code',

Panquesito7 · 2021-12-21T20:02:02Z

src/Commands/source.js

+				.setTitle('Community Classroom Discord bot')
+				.setURL('https://github.com/commclassroom/classroom-monitor-bot')
+				.setAuthor(
+					'Classroon monitor',


Suggested change

'Classroon monitor',

'Classroom Monitor',

Co-authored-by: David Leal <halfpacho@gmail.com>

Panquesito7

Many things are not fixed yet. Please fix them. 🙂

DhansAL · 2021-12-24T12:09:58Z

Many things are not fixed yet. Please fix them. 🙂

please check now ^_^

src/Commands/DSA.js

kaiwalyakoparkar · 2021-12-27T14:12:08Z

@Panquesito7 Can you have a look at this again (As you have gone through once and suggested changes)

Panquesito7 · 2021-12-27T17:37:05Z

src/Commands/DSA.js

+					'Classroon Monitor',
+
+					'Classroom Monitor',


Suggested change

'Classroon Monitor',

'Classroom Monitor',

'Classroom Monitor',

remove extra agrument value in dsa module

DhansAL · 2021-12-28T09:25:28Z

this request took longer than usual @Panquesito7 thanks for reviewing and guiding me through my errors ^_^

DhansAL · 2021-12-29T09:03:35Z

This pull request is covered by pull request #146 .

Panquesito7

These are all the issues that I see. After this, I'll give my approval. 🚀

Panquesito7 · 2021-12-29T15:50:31Z

src/Commands/DSA.js

+				.setTitle('Community Classroom DSA course details')
+				.setURL('https://github.com/commclassroom/classroom-monitor-bot')
+				.setAuthor(
+					'Classroon Monitor',


Suggested change

'Classroon Monitor',

'Classroom Monitor',

Panquesito7 · 2021-12-29T15:54:39Z

src/Commands/DSA.js

+				)
+				.setTimestamp()
+				.setFooter(
+					'Want help? Classroom monitor is just `cm!help` far',


Suggested change

'Want help? Classroom monitor is just `cm!help` far',

'Want help? Classroom Monitor is just `cm!help` far',

Panquesito7 · 2021-12-29T15:54:49Z

src/Commands/help.js

+				.setTitle('Community monitor for help')
+				.setURL('https://github.com/commclassroom/classroom-monitor-bot')
+				.setAuthor(
+					'Classroon Monitor',


Suggested change

'Classroon Monitor',

'Classroom Monitor',

Panquesito7 · 2021-12-29T15:54:57Z

src/Commands/help.js

+				})
+				.setTimestamp()
+				.setFooter(
+					'Want help? Classroom monitor is just `cm!help` far',


Suggested change

'Want help? Classroom monitor is just `cm!help` far',

'Want help? Classroom Monitor is just `cm!help` far',

Panquesito7 · 2021-12-29T15:55:04Z

src/Commands/links.js

+				.setTitle('Community Classroom Social accounts')
+				.setURL('https://github.com/commclassroom/classroom-monitor-bot')
+				.setAuthor(
+					'Classroon Monitor',


Suggested change

'Classroon Monitor',

'Classroom Monitor',

Panquesito7 · 2021-12-29T15:55:13Z

src/Commands/links.js

+				)
+				.setTimestamp()
+				.setFooter(
+					'Want help? Classroom monitor is just `cm!help` far',


Suggested change

'Want help? Classroom monitor is just `cm!help` far',

'Want help? Classroom Monitor is just `cm!help` far',

Panquesito7 · 2021-12-29T15:55:20Z

src/Commands/source.js

+				.setTitle('Community Classroom Discord bot')
+				.setURL('https://github.com/commclassroom/classroom-monitor-bot')
+				.setAuthor(
+					'Classroon Monitor',


Suggested change

'Classroon Monitor',

'Classroom Monitor',

Panquesito7 · 2021-12-29T15:55:27Z

src/Commands/source.js

+				})
+				.setTimestamp()
+				.setFooter(
+					'Want help? Classroom monitor is just `cm!help` far',


Suggested change

'Want help? Classroom monitor is just `cm!help` far',

'Want help? Classroom Monitor is just `cm!help` far',

DhansAL · 2021-12-29T16:27:31Z

done!

Panquesito7

LGTM 🚀 Thank you for your contribution! 😄👍

DhansAL added 4 commits December 16, 2021 11:24

perf: restructured files

d23cb77

add src directory and refactor imports

feat: add custom logger

e5944df

add a custom loghandler util function

feat: custom error handler

0897051

create a custom error handler with sending error as embbed message functionality

feat: log and error custom handlers

4e383a0

restructure code ,create custom loggers,add error handling in all modules

github-actions bot reviewed Dec 16, 2021

View reviewed changes

DhansAL changed the title ~~Loghandler#141~~ feat: Custom log and error handlers Dec 16, 2021

Panquesito7 added ✨ goal: improvement 💻 aspect: code labels Dec 16, 2021

Panquesito7 suggested changes Dec 16, 2021

View reviewed changes

refactor: fix grammatical bugs in code

cb6527a

DhansAL requested a review from Panquesito7 December 19, 2021 06:22

Panquesito7 requested review from kaiwalyakoparkar, siddhant-khisty and Vyvy-vi December 20, 2021 02:47

siddhant-khisty reviewed Dec 20, 2021

View reviewed changes

DhansAL and others added 3 commits December 20, 2021 17:46

Merge branch 'commclassroom:main' into main

6bd29f6

fix: resolve typos and remove university leader programme

fa651ae

Merge branch 'main' of github.com:DhansAL/classroom-monitor-bot

b65f71d

siddhant-khisty approved these changes Dec 21, 2021

View reviewed changes

Panquesito7 suggested changes Dec 21, 2021

View reviewed changes

Update src/Commands/DSA.js

291166d

Co-authored-by: David Leal <halfpacho@gmail.com>

Panquesito7 suggested changes Dec 22, 2021

View reviewed changes

DhansAL added 3 commits December 24, 2021 17:34

refactor: fix typos

46ad8db

refactor: minor changes

eb26ff8

fix: minor fix

7d99464

Panquesito7 reviewed Dec 27, 2021

View reviewed changes

src/Commands/DSA.js Outdated Show resolved Hide resolved

fix: minor fixes

3dad8d5

Panquesito7 reviewed Dec 27, 2021

View reviewed changes

fix: remove extra argument

9ec0b2d

remove extra agrument value in dsa module

Panquesito7 approved these changes Dec 29, 2021

View reviewed changes

refactor: minor typos

53c04b1

Panquesito7 approved these changes Dec 29, 2021

View reviewed changes

Panquesito7 requested a review from siddhant-khisty December 29, 2021 16:29

Panquesito7 merged commit dcda152 into WeMakeDevs:main Dec 30, 2021

DhansAL deleted the loghandler#141 branch December 30, 2021 15:28

	url: 'https://github.com/commclassroom/classroom-monitor-bot.',
	url: 'https://github.com/commclassroom/classroom-monitor-bot',

	'Open source discord bot made for ✨Community Classroom✨'
	'Open Source Discord bot made by and for ✨Community Classroom✨'

	description: 'sends the help command',
	description: 'Sends a list of valid commands (a.k.a. help command)',

	description: 'sends the link relevant to comm classroom',
	description: 'Sends all Community Classroom's socials',

	description: 'sends the source code of the bot',
	description: 'Sends a link to the bot's source code',

	'Want help? Classroom monitor is just `cm!help` far',
	'Want help? Classroom Monitor is just `cm!help` far',

feat: Custom log and error handlers #142

feat: Custom log and error handlers #142

Conversation

DhansAL commented Dec 16, 2021 • edited Loading

Description

Check List (mark all applicable checkboxes)

Screenshots (if applicable)

github-actions bot left a comment

Choose a reason for hiding this comment

Yeah! You did it 🎉 Now, Relax 😉 -> Grab a drink ☕ -> And wait for the maintainers to check your contributions. Meanwhile, you can discuss on other issues and solve them 😀

Panquesito7 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DhansAL commented Dec 17, 2021

DhansAL commented Dec 19, 2021

siddhant-khisty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DhansAL commented Dec 20, 2021 • edited Loading

siddhant-khisty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Panquesito7 left a comment

Choose a reason for hiding this comment

DhansAL commented Dec 24, 2021

kaiwalyakoparkar commented Dec 27, 2021

Choose a reason for hiding this comment

DhansAL commented Dec 28, 2021 • edited Loading

DhansAL commented Dec 29, 2021

Panquesito7 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DhansAL commented Dec 29, 2021

Panquesito7 left a comment

Choose a reason for hiding this comment

DhansAL commented Dec 16, 2021 •

edited

Loading

DhansAL commented Dec 20, 2021 •

edited

Loading

DhansAL commented Dec 28, 2021 •

edited

Loading