Skip to content
This repository has been archived by the owner on Sep 7, 2024. It is now read-only.

use action/checkout@v4 #776

Closed
wants to merge 1 commit into from
Closed

Conversation

shivam-sharma7
Copy link
Contributor

@shivam-sharma7 shivam-sharma7 commented Sep 5, 2023

Fixes Issue

This PR fixes the following issues:

closes #issue-number

Changes proposed

Here comes all the changes proposed through this PR

Check List (Check all the boxes which are applicable)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Add all the screenshots which support your changes

Summary by CodeRabbit

"Chore: Updated GitHub Actions"

  • Upgraded actions/checkout action to v4 in .github/workflows/codeql.yml, .github/workflows/node.js.yml, and .github/workflows/pages-deploy.yaml for improved performance and bug fixes.
  • Upgraded actions/setup-node action to v4 in .github/workflows/node.js.yml introducing potential new features and improvements.

@coderabbitai
Copy link

coderabbitai bot commented Sep 5, 2023

Walkthrough

The changes across the workflows primarily involve upgrading the versions of actions/checkout and actions/setup-node actions. These updates may introduce new features, bug fixes, or improvements, enhancing the overall efficiency and reliability of the workflows.

Changes

File Path Summary
.github/workflows/codeql.yml Upgraded actions/checkout from v3 to v4.
.github/workflows/node.js.yml Upgraded actions/checkout and actions/setup-node from v3 to v4.
.github/workflows/pages-deploy.yaml Upgraded actions/checkout from v2 to v4.

🐇💻

In the land of code where the shadows lie,

We update, we fix, we amplify.

Actions checked out, one, two, three, four,

With every version, we offer more.

So here's to progress, swift and bright,

Guiding our code through the endless night. 🌙✨


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance. The bot stays silent unless called upon.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 6d29dc7 and 904488c commits.
Files selected for processing (3)
  • .github/workflows/codeql.yml (1 hunks)
  • .github/workflows/node.js.yml (1 hunks)
  • .github/workflows/pages-deploy.yaml (1 hunks)
Files skipped from review due to trivial changes (3)
  • .github/workflows/codeql.yml
  • .github/workflows/node.js.yml
  • .github/workflows/pages-deploy.yaml

@AnuragThePathak
Copy link
Contributor

Do you know any projects using actions/checkout@v4 to confirm that we are good to upgrade to it?

@shivam-sharma7
Copy link
Contributor Author

Do you know any projects using actions/checkout@v4 to confirm that we are good to upgrade to it?

See a Red Hat project-https://github.com/quarkiverse/quarkus-quinoa/blob/fff18d9b5b3bb6e92926ca9572911f1523d8bf9f/.github/workflows/build.yml#L31

@AnuragThePathak AnuragThePathak added the freeze This issue/PR is on hold for the moment label Sep 7, 2023
@AnuragThePathak
Copy link
Contributor

@shivam-sharma7 I have that v4 is released only 4 days ago. So not deciding to upgrade now as we do not have any problems with the existing versions and unsure about bugs and other problems in the new version.

@shivam-sharma7
Copy link
Contributor Author

@AnuragThePathak take your time:)

@AnuragThePathak
Copy link
Contributor

@shivam-sharma7 as you can see the v4 has some bugs actions/checkout#1487. So we won't be merging it now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
freeze This issue/PR is on hold for the moment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants