-
Notifications
You must be signed in to change notification settings - Fork 315
Conversation
WalkthroughThe changes across the workflows primarily involve upgrading the versions of Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (3)
- .github/workflows/codeql.yml (1 hunks)
- .github/workflows/node.js.yml (1 hunks)
- .github/workflows/pages-deploy.yaml (1 hunks)
Files skipped from review due to trivial changes (3)
- .github/workflows/codeql.yml
- .github/workflows/node.js.yml
- .github/workflows/pages-deploy.yaml
Do you know any projects using actions/checkout@v4 to confirm that we are good to upgrade to it? |
See a Red Hat project-https://github.com/quarkiverse/quarkus-quinoa/blob/fff18d9b5b3bb6e92926ca9572911f1523d8bf9f/.github/workflows/build.yml#L31 |
@shivam-sharma7 I have that v4 is released only 4 days ago. So not deciding to upgrade now as we do not have any problems with the existing versions and unsure about bugs and other problems in the new version. |
@AnuragThePathak take your time:) |
@shivam-sharma7 as you can see the v4 has some bugs actions/checkout#1487. So we won't be merging it now. |
Fixes Issue
This PR fixes the following issues:
closes #issue-number
Changes proposed
Here comes all the changes proposed through this PR
Check List (Check all the boxes which are applicable)
Screenshots
Add all the screenshots which support your changes
Summary by CodeRabbit
"Chore: Updated GitHub Actions"
actions/checkout
action tov4
in.github/workflows/codeql.yml
,.github/workflows/node.js.yml
, and.github/workflows/pages-deploy.yaml
for improved performance and bug fixes.actions/setup-node
action tov4
in.github/workflows/node.js.yml
introducing potential new features and improvements.