Base setup #3
Merged
Base setup #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Function and Tests to Extract Issue Numbers from a String
kairadiagne
reviewed
Jan 20, 2020
kairadiagne
reviewed
Jan 20, 2020
| @@ -3,7 +3,7 @@ import XCTest | |||
| #if !canImport(ObjectiveC) | |||
| public func allTests() -> [XCTestCaseEntry] { | |||
| return [ | |||
| testCase(ChangelogProducerTests.allTests), | |||
| // testCase(ChangelogProducerTests.allTests), | |||
There was a problem hiding this comment.
Why is this code commented out? Do we need it for running the test?
There was a problem hiding this comment.
We're not keeping the SPM tests up to date for now but it's good to keep it in place for if we ever like to add it back. That's why I simply commented it out for now!
kairadiagne
approved these changes
Jan 20, 2020
kairadiagne
requested changes
Jan 20, 2020
Co-Authored-By: Kaira <kaira@wetransfer.com>
Boris-Em
reviewed
Jan 20, 2020
| // ChangelogBuilder.swift | ||
| // ChangelogProducerCore | ||
| // | ||
| // Created by Antoine van der Lee on 16/01/2020. |
There was a problem hiding this comment.
Shouldn't the copyright be included in the files?
There was a problem hiding this comment.
Good point, I'll add that!
Boris-Em
approved these changes
Jan 20, 2020
…logProducer into feature/input-commands
kairadiagne
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, sorry for making this PR so big. Due to Play Day I had build everything at once but a bit too hacky. Therefore, I decided to rewrite it before opening the PR.
It does result in code that looks as good as I think it could. I'm really interested to hear your feedback on it.