Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error that happened due to naming changes in OctoKit. #66

Conversation

kairadiagne
Copy link
Contributor

@kairadiagne kairadiagne commented Feb 18, 2021

Octokit was updated and therefore the project did not compile anymore. Because of this our CI pipeline failed.
Like we discussed I also checked in the package.resolved file so that we won't run int a similar issue again.

@wetransferplatform
Copy link
Collaborator

wetransferplatform commented Feb 18, 2021

Messages
📖

View more details on Bitrise

📖 GitBuddy-Package: Executed 51 tests, with 0 failures (0 unexpected) in 1.959 (2.034) seconds

GitBuddyCore.framework: Coverage: 88.03

File Coverage
PullRequestFetcher.swift 97.22%
IssuesFetcher.swift 95.92%

Generated by 🚫 Danger Swift against 16790bd

@kairadiagne kairadiagne merged commit e245e10 into master Feb 18, 2021
@kairadiagne kairadiagne deleted the feature/fix-compilation-error-related-to-new-ockotkit-version branch February 18, 2021 12:44
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 3.1.1 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants