Make use of the target commitish date #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AvdLee
requested review from
amirdew and
BasThomas
and removed request for
Boris-Em
Code Coverage Report
Generated by 🚫 Danger Swift against d76f082 |
amirdew
approved these changes
Jan 26, 2022
kevinrenskers
approved these changes
Jan 26, 2022
|
Congratulations! 🎉 This was released as part of Release 4.1.0 🚀 Generated by GitBuddy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scenarios where a
tagNamewas provided, but nochangelogToTagwe changed the code to throw anError.changelogTargetDateMissing.However, there's another scenario that we did not solve here:
tagNameto use for the to be created tag. ThechangelogToTagin this case is thetargetCommitishdateWe did not support this correctly, so I added another fallback to fetch the date using the target commitish.