This repository was archived by the owner on Jan 7, 2026. It is now read-only.
Multi orientation support #185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 1, 2019 14:54
…eVideoOrientation extension
…pertyOrientation extension
… for it's popover
ghost
reviewed
Oct 1, 2019
| self.init(rawValue: AVCaptureVideoOrientation.portraitUpsideDown.rawValue) | ||
| default: | ||
| self.init(rawValue: AVCaptureVideoOrientation.portrait.rawValue) | ||
| case .portrait: self = .portrait |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| default: | ||
| self.init(rawValue: AVCaptureVideoOrientation.portrait.rawValue) | ||
| case .portrait: self = .portrait | ||
| case .portraitUpsideDown: self = .portraitUpsideDown |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| self.init(rawValue: AVCaptureVideoOrientation.portrait.rawValue) | ||
| case .portrait: self = .portrait | ||
| case .portraitUpsideDown: self = .portraitUpsideDown | ||
| case .landscapeLeft: self = .landscapeLeft |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| case .portrait: self = .portrait | ||
| case .portraitUpsideDown: self = .portraitUpsideDown | ||
| case .landscapeLeft: self = .landscapeLeft | ||
| case .landscapeRight: self = .landscapeRight |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| case .portraitUpsideDown: self = .portraitUpsideDown | ||
| case .landscapeLeft: self = .landscapeLeft | ||
| case .landscapeRight: self = .landscapeRight | ||
| case .faceUp: self = .portrait |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| case .landscapeLeft: self = .landscapeLeft | ||
| case .landscapeRight: self = .landscapeRight | ||
| case .faceUp: self = .portrait | ||
| case .faceDown: self = .portraitUpsideDown |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| case .landscapeRight: self = .landscapeRight | ||
| case .faceUp: self = .portrait | ||
| case .faceDown: self = .portraitUpsideDown | ||
| default: self = .portrait |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| /// Maps UIInterfaceOrientation to AVCaptureVideoOrientation | ||
| init?(interfaceOrientation: UIInterfaceOrientation) { | ||
| switch interfaceOrientation { | ||
| case .portrait: self = .portrait |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| init?(interfaceOrientation: UIInterfaceOrientation) { | ||
| switch interfaceOrientation { | ||
| case .portrait: self = .portrait | ||
| case .portraitUpsideDown: self = .portraitUpsideDown |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| switch interfaceOrientation { | ||
| case .portrait: self = .portrait | ||
| case .portraitUpsideDown: self = .portraitUpsideDown | ||
| case .landscapeLeft: self = .landscapeLeft |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| case .portrait: self = .portrait | ||
| case .portraitUpsideDown: self = .portraitUpsideDown | ||
| case .landscapeLeft: self = .landscapeLeft | ||
| case .landscapeRight: self = .landscapeRight |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| case .portraitUpsideDown: self = .portraitUpsideDown | ||
| case .landscapeLeft: self = .landscapeLeft | ||
| case .landscapeRight: self = .landscapeRight | ||
| default: return nil |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
|
|
||
| init(deviceOrientation: UIDeviceOrientation) { | ||
| switch deviceOrientation { | ||
| case .portrait: self = .up |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| init(deviceOrientation: UIDeviceOrientation) { | ||
| switch deviceOrientation { | ||
| case .portrait: self = .up | ||
| case .portraitUpsideDown: self = .down |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| switch deviceOrientation { | ||
| case .portrait: self = .up | ||
| case .portraitUpsideDown: self = .down | ||
| case .landscapeLeft: self = .left |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| case .portrait: self = .up | ||
| case .portraitUpsideDown: self = .down | ||
| case .landscapeLeft: self = .left | ||
| case .landscapeRight: self = .right |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| case .portraitUpsideDown: self = .down | ||
| case .landscapeLeft: self = .left | ||
| case .landscapeRight: self = .right | ||
| case .unknown: self = .up |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| case .landscapeLeft: self = .left | ||
| case .landscapeRight: self = .right | ||
| case .unknown: self = .up | ||
| case .faceUp: self = .up |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| case .landscapeRight: self = .right | ||
| case .unknown: self = .up | ||
| case .faceUp: self = .up | ||
| case .faceDown: self = .up |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
|
|
||
| init(interfaceOrientation: UIInterfaceOrientation) { | ||
| switch interfaceOrientation { | ||
| case .portrait: self = .up |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| init(interfaceOrientation: UIInterfaceOrientation) { | ||
| switch interfaceOrientation { | ||
| case .portrait: self = .up | ||
| case .portraitUpsideDown: self = .up |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| switch interfaceOrientation { | ||
| case .portrait: self = .up | ||
| case .portraitUpsideDown: self = .up | ||
| case .landscapeLeft: self = .left |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| case .portrait: self = .up | ||
| case .portraitUpsideDown: self = .up | ||
| case .landscapeLeft: self = .left | ||
| case .landscapeRight: self = .right |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
| case .portraitUpsideDown: self = .up | ||
| case .landscapeLeft: self = .left | ||
| case .landscapeRight: self = .right | ||
| case .unknown: self = .up |
There was a problem hiding this comment.
| Cases inside a switch should always be on a newline |
ghost
reviewed
Oct 1, 2019
|
|
||
| override func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) { | ||
| super.viewWillTransition(to: size, with: coordinator) | ||
| coordinator.animate(alongsideTransition: { [weak self] (context) in |
There was a problem hiding this comment.
| Unused parameter “context” in a closure should be replaced with _. |
Current coverage for WeScan is
|
| Files changed | - | - |
|---|---|---|
| CGImagePropertyOrientation.swift | 0.00% |
💀 |
| UIInterfaceOrientation+Utils.swift | 0.00% |
💀 |
| ScannerViewController.swift | 0.00% |
💀 |
| CaptureSessionManager.swift | 0.00% |
💀 |
| AVCaptureVideoOrientation+Utils.swift | 55.00% |
|
| Quadrilateral.swift | 89.04% |
✅ |
Current coverage for WeScanSampleProject is 45.83%
| Files changed | - | - |
|---|---|---|
| UIInterfaceOrientation+Utils.swift | 0.00% |
💀 |
| HomeViewController.swift | 49.61% |
🚫 |
Powered by xcov
Generated by 🚫 Danger
Author
|
That's a lot of emails I received, hope you'll use my work in any way since I won't have time to modify it. |
ghost
mentioned this pull request
|
Has anyone found a fix to allow this in landscape only, not portrait? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings support to iPad and camera rotation (See #76 )