undo & redo support #4863
Open
undo & redo support #4863
+2,762
−911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emptyrivers
added
🎨 Enhancement
|
note that this is downstream of #4844, so I might close that pull request & just fold it into this one |
I think keeping it separate makes more sense, we just need to review the FF PR properly and test it, I haven't done that so far |
|
Yeah, please keep them separate. |
|
an update on progess: majority of controls in WA options now perform undo-able actions. exceptions are:
|
|
(note, this pull has #4982 merged in, for my own sanity. The actual changeset is smaller (though, honestly not that much smaller) |
|
Small graphical request: if either the 'undo' or 'redo' is empty (or the last item in the history), have the text 'fade' (optionally unclickable?) to indicate you can't go any further |
functionality related to undo/redo will be hidden behind this feature until it's 'ready' for the LCD user Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
mostly to accomodate how the commonoptions setall works Signed-off-by: Allen Faure <afaure6@gmail.com>
…saction Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
array entry manipulation & reset to defaults aren't yet supported, and collapsed data needs to be handled better somehow Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
detritus from an ancient (never actually released) time when there was "actionConditions" in auraData Signed-off-by: Allen Faure <afaure6@gmail.com>
This might be wrong, or it might produce spurious empty tables. I'm not sure, though. Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
only difference is one is shown when trigger.check == "update" and the other when trigger.check ~= "update" presumably in the past, these were different in more significant ways Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
not doing customOverlayX because i think that's due for a migration to an array Signed-off-by: Allen Faure <afaure6@gmail.com>
which is used for a lot of trigger options as well as load, apparently Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
(same semantics as table.insert/remove) Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
bonus: this means we don't need to ask for confirmation: user can just undo it Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
Signed-off-by: Allen Faure <afaure6@gmail.com>
InfusOnWoW
added
the
🆕 Feature Preview
|
An experimental build of WeakAuras with the changes in this pull request is available here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you want to test it out, checkout this branch, or download the build artifact, either should have the feature automatically enabled. This feature is (for now) disabled by default on alpha/beta/release builds, though you can enable it via the command
/wa ff undo- this will persist thru a reloadcurrently implemented:
there's still a lot to do, especially for custom options & condition options
(there's other changes to be made undo-able not caught by that grep)