Fix percent progress validation and parsing

[NighthawkSLO]

Description

Current implementation

The progress settings for Set Minimum Progress and Set Maximum Progress have a special validation and parsing function which is too basic and quite broken.

Current implementation of the parser is the regex "(%d+)%%" - digits followed by a literal %, first such match in the string.

Examples of broken parsing

• -12% parsed as 12
• 12.34% parsed as 34
• 12.34 % not parsed
• abcd 12% efgh parsed as 12
• 12%34 parsed as 12

New implementation

Find and replace first instance of a literal % with space (See 5th example for why not empty string). The rest of the work is offloaded to tonumber (which trims leading and trailing whitespace)

Find the % at the end of the string with regex "%% *$". If it is found, the parsing is offloaded to tonumber on the substring before the find.

Fixed examples

• -12% parsed as -12
• 12.34% parsed as 12.34
• 12.34 % parsed as 12.34
• abcd 12% efgh not parsed
• 12%34 not parsed
• %12 not parsed
• 12% abcd not parsed

Type of change

• Bug fix (non-breaking change which fixes an issue)

[InfusOnWoW]

thanks