Smallpatches #5561
Merged
Smallpatches #5561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InfusOnWoW
force-pushed
the
smallpatches
branch
4 times, most recently
from
7e8a667 to
a819fb4
Compare
InfusOnWoW
force-pushed
the
smallpatches
branch
2 times, most recently
from
766c904 to
22049db
Compare
This comment was marked as resolved.
This comment was marked as resolved.
mrbuds
reviewed
Dec 14, 2024
mrbuds
reviewed
Dec 14, 2024
mrbuds
reviewed
Dec 14, 2024
Refactor the existing StopMotion region into something that can be reused by an sub element. Additionally add a way for sub elements to provided anchors to other sub elements and implement Ticks as anchor providers. Cycles in Stop Motion anchoring is prevented by Ticks being not anchoreable to other sub elements. Eventually a more robust solution for preventing anchoring cycles between sub elements will be needed. Also argueably the regions should provide "progress relative" anchoring and this shouldn't be Ticks responsibility, but we'll need sub elements providing anchors anyway.
InfusOnWoW
force-pushed
the
smallpatches
branch
from
22049db to
791fc0e
Compare
mrbuds
reviewed
Dec 20, 2024
By heavily refactoring progress textures. Not every feature of ProgressTexture is supported by these sub elements, missing ones can be added later.
InfusOnWoW
force-pushed
the
smallpatches
branch
from
791fc0e to
bbf82e6
Compare
mrbuds
reviewed
Dec 26, 2024
But only on Cata, as the api is rather awkward and on retail it's equivalent to int. Fixes: WeakAuras#5558
InfusOnWoW
force-pushed
the
smallpatches
branch
from
37d384a to
23fc6d7
Compare
mrbuds
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.