Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions actions to Node 20 #1394

Merged
merged 3 commits into from
May 17, 2024

Conversation

charmander
Copy link
Contributor

Node 16 actions are deprecated.

The Codecov action upgrade introduces a new upload token requirement, which pull requests from forks (which don’t receive the secret) are exempt from according to the action’s documentation.

Node 16 actions are deprecated.

The Codecov action upgrade introduces a new upload token requirement, which pull requests from forks (which don’t receive the secret) are exempt from according to the action’s documentation.
@charmander charmander marked this pull request as draft February 22, 2024 04:23
@charmander
Copy link
Contributor Author

It looks like Codecov’s v4 action doesn’t support Alpine(?) yet. Installing a few packages (glibc and gnupg) in the base image might fix it, but this isn’t a priority and I don’t know if we even want to keep using Codecov.

@charmander charmander force-pushed the github-actions-update branch from 6115298 to 39d1059 Compare May 17, 2024 02:31
@charmander
Copy link
Contributor Author

(even with gcompat,)

Error relocating /tmp/_MEINbGjbD/libz.so.1: crc32_z: symbol not found

i’m so glad codecov upgraded to a “universal binary” :))

Codecov’s v4 action (still) doesn’t work on Alpine despite the new uploader being distributed as a latest-download “universal binary” PGP-verified (ineffectively, since it seems to run the binary even if verification fails?) by the action instead of something sane.
@charmander charmander force-pushed the github-actions-update branch from 95d2d63 to 2127eda Compare May 17, 2024 03:06
@charmander charmander marked this pull request as ready for review May 17, 2024 03:06
@charmander
Copy link
Contributor Author

CI logs:

No token specified or token is empty

Yes, because the source is a fork. Uploads from forks aren’t supposed to require tokens, according to Codecov, for this very reason.

There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 1642s.', code='throttled')}

What if I want to open more than one pull request every 30 minutes?

I think we’re dropping Codecov; I’ll just write an action that adds the coverage summary that we already have, plus maybe one from diff-cover, as a comment.

@charmander charmander merged commit bd86b85 into Weasyl:main May 17, 2024
4 checks passed
@charmander charmander deleted the github-actions-update branch May 17, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant