Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count friends-only posts on own profile #1463

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

charmander
Copy link
Contributor

Discovered by @philpem!

@charmander charmander added the bug label Nov 1, 2024
@charmander charmander requested a review from philpem November 1, 2024 12:14
@charmander charmander changed the title fix: Fix post counts for friends-only posts own profile Count friends-only posts on own profile Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.93%. Comparing base (67f148e) to head (6721724).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1463   +/-   ##
=======================================
  Coverage   61.93%   61.93%           
=======================================
  Files          96       96           
  Lines        9239     9239           
  Branches     1656     1656           
=======================================
  Hits         5722     5722           
  Misses       3044     3044           
  Partials      473      473           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charmander charmander force-pushed the post-counts-own-friends-only branch from 83435fc to 6721724 Compare November 1, 2024 12:30
Copy link
Contributor

@philpem philpem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charmander charmander merged commit 5892ec4 into main Nov 2, 2024
7 checks passed
@charmander charmander deleted the post-counts-own-friends-only branch November 2, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants