Platform upgrades #1469
Merged
Platform upgrades #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y policy Alpine 3.16 is the last to provide a package for ImageMagick 6, and it’s EOL. This adds a security policy (the previous one was “open”, which is a scary thing when you’re talking about this particular piece of software!), and should fix the runaway memory leak when ImageMagick detects that there isn’t enough memory for an operation and writes pixel data as (linked) files to an in-memory filesystem (`/tmp`), guaranteeing that they will now persist in memory after a failure. (It still seems to copy some *inputs* to temporary files, though, so there’s still some leak potential.)
charmander
force-pushed
the
platform-upgrades
branch
5 times, most recently
from
397ab1e to
2a3ea4e
Compare
charmander
force-pushed
the
platform-upgrades
branch
from
2a3ea4e to
13a081b
Compare
huntertur
reviewed
Nov 5, 2024
| <policy domain="resource" name="width" value="16384"/> | ||
| <!-- Set the maximum height of an image. When this limit is exceeded, an | ||
| exception is thrown. --> | ||
| <policy domain="resource" name="height" value="16384"/> |
There was a problem hiding this comment.
Could the 16,384px width and height limits cause any issues for long comics that artists wish to upload as one piece?
I am aware of at least one example of a submission getting near these limits; 15,550px-height image here: https://www.weasyl.com/~trevorfox/submissions/2083323/bori-story
There was a problem hiding this comment.
Maybe, but we have to set the limits somewhere. Notable points:
- “cover” images are already resized to a maximum of 3000 pixels tall
- WebP only supports 16383 pixels per side (which is why I picked this particular limit); AVIF’s limits are even lower
There was a problem hiding this comment.
Basing the limit on WebP's limits is reasonable to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.