Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds sessionId in the state #352

Merged
merged 1 commit into from
Dec 16, 2024
Merged

adds sessionId in the state #352

merged 1 commit into from
Dec 16, 2024

Conversation

arch1995
Copy link
Contributor

@arch1995 arch1995 commented Dec 16, 2024

Motivation and Context

For mobile sfa sdk, sessionId is not present in the session state, hence we need to add this if rehydration is successful

Description

  • adds sessionId in the state if valid.

How has this been tested?

Devrels tested this

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@chaitanyapotti chaitanyapotti merged commit afba46d into master Dec 16, 2024
3 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/session-id-state branch December 16, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants