Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hard link count to 64-bits. #127

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Change hard link count to 64-bits. #127

merged 1 commit into from
Oct 31, 2019

Conversation

peterhuene
Copy link
Contributor

This commit changes the type for __wasi_linkcount_t to 64-bits to support
large link counts.

Fixes #70.

@peterhuene
Copy link
Contributor Author

peterhuene commented Oct 24, 2019

It looks like the default shell on Windows CI changed from cmd to psh?

@alexcrichton
Copy link
Contributor

Ah I think so yeah, you can fix it by inserting shell: bash just under to use bash on all platforms

@peterhuene
Copy link
Contributor Author

I opted for breaking the command into multiple lines rather than &&. Any preference?

.github/workflows/main.yml Outdated Show resolved Hide resolved
@alexcrichton
Copy link
Contributor

I'd be fine either way, but I think @bjorn3 is right in that unfortunately set -e isn't the default. That may have changed though!

This commit changes the type for `__wasi_linkcount_t` to 64-bits to support
large link counts.

Fixes #70.
@sunfishcode sunfishcode merged commit 5a8d999 into WebAssembly:master Oct 31, 2019
cjihrig added a commit to cjihrig/wasi-libc that referenced this pull request Nov 9, 2019
@peterhuene peterhuene deleted the make-linkcount-64-bits branch November 9, 2019 01:46
sunfishcode pushed a commit to WebAssembly/wasi-libc that referenced this pull request Nov 14, 2019
sunfishcode pushed a commit to WebAssembly/wasi-libc that referenced this pull request Nov 22, 2019
sunfishcode added a commit to WebAssembly/wasi-libc that referenced this pull request Nov 22, 2019
* Make __wasi_linkcount_t a uint64_t (#134)

Refs: WebAssembly/WASI#127

* Generate the WASI interface from witx.

This replaces the hand-maintained <wasi/core.h> header with a
<wasi/api.h> generated from witx.

Most of the churn here is caused by upstream WASI renamings; hopefully
in the future ABI updates will be less noisy.
cjihrig added a commit to nodejs/uvwasi that referenced this pull request Dec 4, 2019
cjihrig added a commit to nodejs/uvwasi that referenced this pull request Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make __wasi_linkcount_t 64-bit
4 participants