witx: add support for parsing multiple top-level files #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support in witx to parse multiple top-level witx files. This is an api-breaking change - public functions that previously took an
impl AsRef<Path>
to a witx file now take an&[impl AsRef<Path>]
There is still only one global namespace for all type names and module names across all files. This means that if two top-level files define the same name, the second definition will cause an error, just like it would if both definitions are in the same file. However, if two top-level files depend each depend on a third file which defines a name, the name will only be defined once, and each reference to that name will be equal.
I'd like to fix the scoping issue at some point soon, but for now this unblocks #98.