Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the format of wit files #641

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Unify the format of wit files #641

wants to merge 2 commits into from

Conversation

oovm
Copy link

@oovm oovm commented Jan 30, 2025

I wrote a tool that does project-level formatting: https://plugins.jetbrains.com/plugin/24001-wit-idl

Also respects the rules defined in the .editorconfig file.

The current code style is a bit confusing.

Most file use a mixture of 2 and 4 spaces, some files use 6 spaces, and one uses 7 spaces.

This PR makes all wit files have a unified code style which defined in .editorconfig.


Changes will be synchronized to other upstreams later.

Projects with 0.3.0-draft wit still need some additional development work.

Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC these are mirrors of upstream files?

Would it make sense instead to apply these changes upstream first, to avoid have large downstream differences?

@ricochet
Copy link
Contributor

Thanks for this! These are just mirrors although I don't have an issue with normalizing what we have here while also updating upstream. For the individual proposal repos, we need to also have this run as a lint like we do with wit-abi-up action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants