Change ArenaVector<T>::Iterator to satisfy standard (Legacy)RandomAccessIterator concept #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Mar 25, 2019
src/mixed_arena.h
Outdated
| } | ||
|
|
||
| bool operator<(const Iterator& other) const { | ||
| return (parent->data + index) < (other.parent->data + other.index); |
There was a problem hiding this comment.
I think it's enough to compare the indexes here - as the parent must be identical? (perhaps we should assert on that?)
There was a problem hiding this comment.
Since a < b must be equal to b - a > 0 [*1], I agree that it is better to order only among iterators with the same parent.
509dd76
*1: https://en.cppreference.com/w/cpp/named_req/RandomAccessIterator
| } | ||
|
|
||
| T* operator->() const { | ||
| return &(*parent)[index]; |
There was a problem hiding this comment.
is it common to define () to be identical to * like this?
There was a problem hiding this comment.
not operator () but operator -> to allow it->member_of_T.
…pairs that have the same parent.
|
Great, thanks again @Ryooooooga! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to pass iterators to the functions defined in <algorithm>.