Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate dynCall function for all signature used by invoke functions. #2095

Merged
merged 3 commits into from
May 10, 2019

Conversation

sbc100
Copy link
Member

@sbc100 sbc100 commented May 9, 2019

Previously we were only creating dynCall functions for signatures
that we have statically in the table. However for dynamic linking we
may need to invoke functions that we don't have table entries for
(e.g. table entries from a different module).

@sbc100 sbc100 requested a review from kripken May 9, 2019 23:52
…ons.

Previously we were only creating `dynCall` functions for signatures
that we have statically in the table.  However for dynamic linking we
may need to invoke functions that we don't have table entries for
(e.g. table entries from a different module).
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with comments

src/wasm-emscripten.h Outdated Show resolved Hide resolved
src/wasm/wasm-emscripten.cpp Show resolved Hide resolved
@sbc100 sbc100 merged commit 70434ef into master May 10, 2019
@sbc100 sbc100 deleted the dyncalls branch May 10, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants