DWARF: high_pc computation #2595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
reviewed
Jan 16, 2020
Member
dschuff
left a comment
dschuff
left a comment
There was a problem hiding this comment.
Do we actually have any examples of DW_AT_high_pc [DW_FORM_addr] (i.e. the absolute form) in our test cases?
| 0x00000082: DW_TAG_subprogram [10] * | ||
| DW_AT_low_pc [DW_FORM_addr] (0x0000000000000006) | ||
| DW_AT_high_pc [DW_FORM_data4] (0x00000397) | ||
| DW_AT_high_pc [DW_FORM_data4] (0x00000383) |
Member
There was a problem hiding this comment.
I guess this means that Binaryen shrank the function? Is that expected for this test?
Member
Author
There was a problem hiding this comment.
Yes, it shrinks it a little even without running optimizations, due to LEBs being compressed (which clang doesn't do in all places). I verified that size is correct.
Member
Author
|
We don't seem to have the absolute addr variant - perhaps llvm never emits it? (It does seem less efficient, so seems reasonable it wouldn't. |
dschuff
approved these changes
Jan 16, 2020
awtcode
pushed a commit
to awtcode/binaryen
that referenced
this pull request
Jan 23, 2020
Update high_pc values. These are interesting as they may be a relative offset compared to the low_pc. For functions we already had both a start and an end. Add such tracking for instructions as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
high_pcvalues. These are interesting as theymay be a relative offset compared to the
low_pc.For functions we already had both a start and an end. Add
such tracking for instructions as well.
This PR depends on #2594 (testcase updates).