Limit the number of passive segments to work around a Chrome bug #2613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome is currently decoding the segment indices as signed numbers, so some ranges of indices greater than 63 do not work. As a temporary workaround, limit the number of segments produced by MemoryPacking to 63 when bulk-memory is enabled.
sbc100
approved these changes
Jan 22, 2020
src/passes/MemoryPacking.cpp
Outdated
|
|
||
| // FIXME: Chrome has a bug decoding section indices that prevents it from | ||
| // using more than 63. Just use MaxDataSegments once this is fixed. | ||
| uint32_t MAX_SEGMENTS; |
There was a problem hiding this comment.
It's not actually a constant, but it does fill the role of a constant, so I thought it would be appropriate to name it like a constant. I can change this if you'd like.
There was a problem hiding this comment.
Might want to reference this bug so you know when this can be removed: https://bugs.chromium.org/p/v8/issues/detail?id=10151
There was a problem hiding this comment.
+1 to renaming it, +1 to linking to the bug with a comment like "temporary workaround" etc.
kripken
approved these changes
Jan 22, 2020
src/passes/MemoryPacking.cpp
Outdated
|
|
||
| // FIXME: Chrome has a bug decoding section indices that prevents it from | ||
| // using more than 63. Just use MaxDataSegments once this is fixed. | ||
| uint32_t MAX_SEGMENTS; |
There was a problem hiding this comment.
+1 to renaming it, +1 to linking to the bug with a comment like "temporary workaround" etc.
awtcode
pushed a commit
to awtcode/binaryen
that referenced
this pull request
Jan 23, 2020
…Assembly#2613) Chrome is currently decoding the segment indices as signed numbers, so some ranges of indices greater than 63 do not work. As a temporary workaround, limit the number of segments produced by MemoryPacking to 63 when bulk-memory is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome is currently decoding the segment indices as signed numbers, so
some ranges of indices greater than 63 do not work. As a temporary
workaround, limit the number of segments produced by MemoryPacking to
63 when bulk-memory is enabled.