Skip to content

Fix / uniformize include guards #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2015
Merged

Fix / uniformize include guards #30

merged 1 commit into from
Dec 22, 2015

Conversation

jfbastien
Copy link
Member

No description provided.

@kripken
Copy link
Member

kripken commented Dec 22, 2015

I had somewhat intentionally left AllocatingModule for a side .h, so wasm.h focuses just on the AST and not allocation. But I don't feel strongly about it. What was your thinking here?

@jfbastien
Copy link
Member Author

Checking include guards is icky because it depends on inclusion order. I could move that class to its own header file, but it seem like overkill. No strong preference besides avoiding icky.

@kripken
Copy link
Member

kripken commented Dec 22, 2015

Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants