Refactor getMaxBits() out of OptimizeInstructions and add beginnings of unit testing for it #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you mean to refer to a different PR/issue besides #3012? |
|
Sorry, I think I meant #2879 (but the context there is not necessary to understand this PR). |
tlively
approved these changes
Aug 4, 2020
| compare(CostAnalyzer(&get).cost, 0); | ||
| } | ||
|
|
||
| int main() { |
There was a problem hiding this comment.
I wonder if it would be worth trying to set up a gtest integration here and starting to write more unit tests...
On the other hand, we don't really need yet another way to run tests 😭
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getMaxBitsjust moves around, no logic is changed.Aside from adding
getMaxBits, the change in bits.h is 99% whitespace.helps #2879 cc @MaxGraey