Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Type::expand() with an iterator-based approach #3061

Merged
merged 8 commits into from
Aug 19, 2020

Conversation

dcodeIO
Copy link
Contributor

@dcodeIO dcodeIO commented Aug 19, 2020

As a follow-up to #3012 (comment), this PR replaces Type::expand() incl. its usages with an iterator-based approach.

@dcodeIO dcodeIO changed the title Replace Type::expand() with an interator-based approach Replace Type::expand() with an iterator-based approach Aug 19, 2020
src/wasm/wasm-type.cpp Outdated Show resolved Hide resolved
@dcodeIO
Copy link
Contributor Author

dcodeIO commented Aug 19, 2020

Some early fuzzing

Invocations so far:
   FuzzExec: 2313
   CompareVMs: 580
   CheckDeterminism: 213
   Wasm2JS: 513
   Asyncify: 542

Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

src/wasm-type.h Outdated Show resolved Hide resolved
src/wasm/wasm-type.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants