Add new compound Rtt type #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcodeIO
commented
Aug 24, 2020
dcodeIO
commented
Aug 24, 2020
dcodeIO
commented
Aug 24, 2020
tlively
reviewed
Aug 25, 2020
dcodeIO
commented
Aug 25, 2020
tlively
reviewed
Aug 25, 2020
|
Let me know if you think this is ready for final review. Leaving subtyping to a follow-on PR would be fine, if you'd like. |
|
With the remaining tests added this should be ready for review then :) |
tlively
approved these changes
Aug 26, 2020
| return array; | ||
| } | ||
| std::string toString() const; | ||
| }; |
There was a problem hiding this comment.
It would be good to move the less trivial methods into the .cpp file. I'm thinking roughly anything with a switch in it. My goal there would be consistency with where the TypeInfo methods are placed.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends compound types introduced in #3012 with a representation of
Rtts as described in the GC proposal, by also introducing the concept of aHeapTypeshared betweenTypeInfoandRtt. Again, this should be a non-functional change sinceRtts are not used anywhere yet. Subtyping rules and updating thexrefaliases is left for future work.