Prototype i32x4.widen_i8x16_{s,u} #3535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As proposed in WebAssembly/simd#395. Note that the other instructions in the proposal have not been implemented in LLVM or in V8, so there is no need to implement them in Binaryen right now either. This PR introduces a new expression class for the new instructions because they uniquely take an immediate argument identifying which portion of the input vector to widen.
kripken
approved these changes
Feb 2, 2021
| curr->vec = popNonVoidExpression(); | ||
| curr->finalize(); | ||
| out = curr; | ||
| return true; |
There was a problem hiding this comment.
please use a Builder and call the method on there.
| ret->vec = parseExpression(s[2]); | ||
| ret->finalize(); | ||
| return ret; | ||
| } |
|
Heh, I did not read the later comment and so it did an auto-merge... anyhow, my comments were not urgent. |
|
What do I need to do to test this with emscripten and clang? |
|
In a few hours there should be a new tip of tree build with this included. You can then do Or, you can build binaryen manually and point emscripten to that location by editing the |
|
Okay cool! Will let you guys know how it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in WebAssembly/simd#395. Note that the other
instructions in the proposal have not been implemented in LLVM or in V8, so
there is no need to implement them in Binaryen right now either. This PR
introduces a new expression class for the new instructions because they uniquely
take an immediate argument identifying which portion of the input vector to
widen.