[EH] Allow catch/delegate-less trys #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the restriction that `try` should have at least one `catch`/`catch_all`/`delegate`. See WebAssembly/exception-handling#157.
tlively
approved these changes
Jun 7, 2021
src/wasm/wasm-binary.cpp
Outdated
| if (lastSeparator != BinaryConsts::Catch && | ||
| lastSeparator != BinaryConsts::CatchAll && | ||
| lastSeparator != BinaryConsts::Delegate) { | ||
| throwError("No catch instruction within a try scope"); | ||
| throwError("try scope should contain only catch/catch_all/delegate"); |
There was a problem hiding this comment.
IIUC, this will never happen because the only other value lastSeparator could have is BinaryConsts::End, which is already handled. Is this intentionally meant to be future-proof against new separators being added in the future? If not, it might be simpler just to remove this check entirely.
kripken
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the restriction that
tryshould have at least onecatch/catch_all/delegate. See WebAssembly/exception-handling#157.